Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notes to address joeys questions #41

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mackenziewildman
Copy link
Contributor

No description provided.

Copy link
Contributor

@kespinola kespinola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notes on the db setup.

Comment on lines 118 to 121
```
npm run reset
npm run generate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have notes on the reset to clear and recreate the db but npm run generate should be added as a must do step. Once environment is up go to shell and run npm run db.

Remove npm run generate that is only for development and just running npm reset will delete the database, re-create it and re-run migrations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the info!! making sure i understand - we've got npm run db in the instructions, under "Set up the database". and i updated the reset instructions to include only npm run reset and not npm run generate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants